[1518] Directory Name Render and Create Fix#1991
Merged
jensens merged 10 commits intocookiecutter:mainfrom Mar 20, 2024
Merged
Conversation
jensens
previously approved these changes
Mar 18, 2024
for more information, see https://pre-commit.ci
jensens
approved these changes
Mar 19, 2024
|
Wait. I want the exact opposite, i.e. the ability to skip directories when rendering. It works for files by using an empty filename, so it should work for directories as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue described in #1518. Written by @rafyak and @DanielZhangD
The solution was to add a check to render_and_create_dir to make sure the dirname was not empty.
Testing was completed via adding a new unit tests for render_and_create_dir and making sure coverage stayed at 100%