Implement new style for nested templates config#1981
Merged
Conversation
kurtmckee
suggested changes
Nov 18, 2023
Member
|
Thanks for tagging me to review this! I hope the feedback is helpful. Have a great weekend! |
kurtmckee
reviewed
Nov 20, 2023
Member
kurtmckee
left a comment
There was a problem hiding this comment.
One last follow-up question regarding whether a list or dict should be the default value.
Member
Author
|
The old format expects a list of strings. |
kurtmckee
approved these changes
Nov 20, 2023
Member
|
Note: The Windows tests are failing due to the absolute paths tests. |
|
Hello! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for new format:
{ "templates": { "project-1": { "path": "./project-1", "title": "Project 1", "description": "A cookiecutter template for a project" }, "package": { "path": "./package", "title": "Package", "description": "A cookiecutter template for a package" } } }Closes #1980