Fix FileExistsError when using a relative template path#1968
Conversation
When using a local cookiecutter template ('cookiecutter .')
that contains a pre_prompt script, cookiecutter will exit
with a FileExistsError. The stack trace hints that the temporary
directory already exists and cannot be created by shutils.copytree.
By converting repo_dir into a Path object and calling resolve
to get the absolute path the actual name of the directory is used
instead of '.'.
ericof
approved these changes
Nov 9, 2023
Member
ericof
left a comment
There was a problem hiding this comment.
Thank you for fixing this issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a local cookiecutter template that contains a pre_prompt script, cookiecutter will exit with a FileExistsError.
Reason for the FileExistsError is the input to
create_tmp_repo_dir()which is just a simple dot. By converting the input into a Path object and using thePath.resolve()method we get the absolute path instead of the relative(.) andshutils.copytree()runs without an error.OS: Windows 10
Launch Command:
cookiecutter . --overwrite-if-existsFixes #1972