Default values can be passed as a dict#1924
Merged
ericof merged 4 commits intocookiecutter:mainfrom Nov 17, 2023
Merged
Conversation
kurtmckee
approved these changes
Nov 15, 2023
Member
kurtmckee
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for including a test case!
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using cookiecutter programatically and generating some config values (replay_dir to be specific) dynamically. So, I need ability to pass it from the outside.
Maybe I'm wrong, but it seems like current version doesn't allow to do that. Creating config file time for every call of the cookiecutter sounds like an overhead to me.
Here's my small suggestion how this functionality can be added without introducing breaking changes into the API.