Skip to content

docs: add warning for jinja2_time#1890

Merged
ericof merged 1 commit intocookiecutter:mainfrom
henryiii:henryiii/docs/time_warning
Jul 10, 2023
Merged

docs: add warning for jinja2_time#1890
ericof merged 1 commit intocookiecutter:mainfrom
henryiii:henryiii/docs/time_warning

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

@henryiii henryiii commented Jul 7, 2023

See #1888. This is a suggested docs addition.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@tranzystorekk
Copy link
Copy Markdown
Contributor

I wonder if it would be better to instead make the whole example more generic and obvious, e.g. by specifying a placeholder extension like foobar.FoobarExtension.

A warning after a potentially confusing example might just make the whole doc more confusing effectively.

@ericof ericof self-requested a review July 10, 2023 00:30
@ericof ericof added this to the 3.0.0 milestone Jul 10, 2023
@ericof ericof added the documentation This issue/PR relates to or includes documentation. label Jul 10, 2023
Copy link
Copy Markdown
Member

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @henryiii!

@ericof ericof merged commit bdd0f14 into cookiecutter:main Jul 10, 2023
@ericof ericof modified the milestones: 3.0.0, 2.2.2 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This issue/PR relates to or includes documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants