Skip to content

Improve gitignore#1889

Merged
ericof merged 3 commits intomainfrom
improve-gitignore
Jul 10, 2023
Merged

Improve gitignore#1889
ericof merged 3 commits intomainfrom
improve-gitignore

Conversation

@audreyfeldroy
Copy link
Copy Markdown
Member

Just some little .gitignore improvements to ease the maintenance burden and make contribution a little nicer.

* "Adapted from" clarifies that it is our own .gitignore now (as opposed to one that stays true to just the source)
* Reference URL is now the non-raw version on GitHub, making it easier to understand which repo it came from
Comment on lines +164 to +168
# VSCode settings (e.g. .vscode/settings.json containing personal preferred path to venv)
.vscode/

# macOS auto-generated file
.DS_Store
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this! It may be worthwhile to put these at the top of the file so that they're more prominent.

@ericof ericof added the CI/CD This issue/PR relates to the project CI/CD update or fix. label Jul 10, 2023
@ericof ericof added this to the 3.0.0 milestone Jul 10, 2023
@ericof ericof self-requested a review July 10, 2023 00:28
@ericof ericof merged commit b274ce9 into main Jul 10, 2023
@ericof ericof deleted the improve-gitignore branch July 10, 2023 00:29
@ericof ericof modified the milestones: 3.0.0, 2.2.2 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD This issue/PR relates to the project CI/CD update or fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants