Skip to content

Update .gitignore and cite where it was copied from#1879

Merged
ericof merged 1 commit intocookiecutter:mainfrom
kurtmckee:update-gitignore
Jul 4, 2023
Merged

Update .gitignore and cite where it was copied from#1879
ericof merged 1 commit intocookiecutter:mainfrom
kurtmckee:update-gitignore

Conversation

@kurtmckee
Copy link
Copy Markdown
Member

The source is clear from the various in-file comments; now it is updated and cited.

I routinely use .venv/ as my virtual environment directory, which was not included in the old version of the Python-gitignore file. Now it is included, and I don't have to mentally ignore that directory when committing changes. 🥳 🎈 📈

The source is clear from the various in-file comments;
now it is updated and cited.
@kurtmckee kurtmckee requested review from ericof, jensens and pydanny July 3, 2023 14:07
Copy link
Copy Markdown
Member

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtmckee
Copy link
Copy Markdown
Member Author

Huzzah! Would you be willing to merge in that case?

@ericof ericof added the CI/CD This issue/PR relates to the project CI/CD update or fix. label Jul 4, 2023
@ericof ericof added this to the 2.2.0 milestone Jul 4, 2023
@ericof ericof merged commit ab3cf63 into cookiecutter:main Jul 4, 2023
@kurtmckee kurtmckee deleted the update-gitignore branch July 5, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD This issue/PR relates to the project CI/CD update or fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants