Skip to content

Standardize newlines for all platforms#1870

Merged
jensens merged 1 commit intocookiecutter:mainfrom
kurtmckee:standardize-newlines
Jun 26, 2023
Merged

Standardize newlines for all platforms#1870
jensens merged 1 commit intocookiecutter:mainfrom
kurtmckee:standardize-newlines

Conversation

@kurtmckee
Copy link
Copy Markdown
Member

This resolves pre-commit hook failures that occur on Windows. The .gitattributes file forced CRLF newlines on all files via "text=auto", which caused linting to fail.

LF newlines are now enforced for all files except those with "crlf" in their filenames.

@kurtmckee kurtmckee force-pushed the standardize-newlines branch 5 times, most recently from cafcf48 to 4d22505 Compare June 19, 2023 16:20
This resolves pre-commit hook failures that occur on Windows.
The `.gitattributes` file forced CRLF newlines on all files,
which caused linting to fail.

LF newlines are now enforced for all files
except those with "crlf" in their filenames.
@kurtmckee kurtmckee force-pushed the standardize-newlines branch from 4d22505 to 5e32aee Compare June 19, 2023 16:23
@kurtmckee kurtmckee requested review from ericof and jensens June 26, 2023 12:30
@kurtmckee kurtmckee self-assigned this Jun 26, 2023
Copy link
Copy Markdown
Contributor

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will do it.

@kurtmckee
Copy link
Copy Markdown
Member Author

kurtmckee commented Jun 26, 2023

I think this will do it.

Do you mean, "This approval will allow you to merge?" My username doesn't have write access to the repo, so I'll need you to merge if the PR looks good-to-go. 😄

@jensens jensens merged commit ca8d9dd into cookiecutter:main Jun 26, 2023
@kurtmckee kurtmckee deleted the standardize-newlines branch June 26, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants