Skip to content

Update base docs, remove tox#1858

Merged
jensens merged 4 commits intomainfrom
issue-1857
Jun 13, 2023
Merged

Update base docs, remove tox#1858
jensens merged 4 commits intomainfrom
issue-1857

Conversation

@ericof
Copy link
Copy Markdown
Member

@ericof ericof commented Jun 13, 2023

Fixes #1857

@ericof ericof added documentation This issue/PR relates to or includes documentation. CI/CD This issue/PR relates to the project CI/CD update or fix. labels Jun 13, 2023
@ericof ericof requested a review from jensens June 13, 2023 09:19
@kurtmckee
Copy link
Copy Markdown
Member

I would prefer to stick with tox and remove nox instead.

@jensens jensens merged commit 8fbc5e4 into main Jun 13, 2023
@jensens jensens deleted the issue-1857 branch June 13, 2023 13:04
@ericof
Copy link
Copy Markdown
Member Author

ericof commented Jun 13, 2023

@kurtmckee To be honest, it is not a big difference. And it seems our nice friends at pypa like it, so we are not adopting something that is unmaintained.

@ericof ericof added this to the 2.2.0 milestone Jun 13, 2023
@kurtmckee
Copy link
Copy Markdown
Member

kurtmckee commented Jun 16, 2023

I much more strongly disagree with this now that I've attempted to run the tests on Windows.

nox is finding PyPy 3.9 and believes that it's CPython 3.9. It's not able to find 4 of my installed CPython versions.

This appears to be happening because PyPy 3.9 and CPython 3.11 are the only ones on my PATH (and my virtual environment was created using Python 3.11). The nox documentation says that it finds Python versions on Windows using the py launcher, which I don't have installed.

nox -- on Windows, anyway -- appears to be an inferior product to tox in this regard, and I would like to revert this change and use tox instead.

@kurtmckee
Copy link
Copy Markdown
Member

@ericof Please let me know if reverting this change and standardizing on tox will be acceptable.

@ericof
Copy link
Copy Markdown
Member Author

ericof commented Jun 16, 2023

@kurtmckee open a PR reverting all nox changes

@ssbarnea
Copy link
Copy Markdown
Member

Not sure what happened with this as the code review failed to check about other tox lefovers,

https://github.com/search?q=repo%3Acookiecutter%2Fcookiecutter%20tox&type=code reports lots of files referring to tox.

@kurtmckee
Copy link
Copy Markdown
Member

@ssbarnea I'm pretty sure that I reverted the changes a long time ago, as discussed above.

#2157 discarded the tox configuration in the last 24 hours, so the old discussion here has become very irrelevant to the current state of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD This issue/PR relates to the project CI/CD update or fix. documentation This issue/PR relates to or includes documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING, README and package metadata

4 participants