Bugfix/jinja2 change delimiters of the template folder#1837
Bugfix/jinja2 change delimiters of the template folder#1837mariovagomarzal wants to merge 8 commits intocookiecutter:mainfrom mariovagomarzal:fix-jinja2-delimiters
Conversation
There was a problem hiding this comment.
@mariovagomarzal Thanks for re-triggering CI after the lint-fixing PR was merged, and for adding a test to demonstrate this bug is fixed!
@audreyfeldroy @jensens @tmeckel Please merge this PR to close #1736. Thanks!
| and environment.variable_start_string in str_path | ||
| and environment.variable_end_string in str_path |
There was a problem hiding this comment.
This, and the similar change in generate.py, are the crucial elements of this bugfix. Nice!
|
This changes the signature of the functions -> breaking change. |
|
As this is a breaking change, we will add it to the 3.0.0 milestone |
|
Would it be sufficient to give the def find(x, environment = None):
left_delimiter = "{{"
right_delimiter = "}}"
if environment is not None:
left_delimiter = environment.x
right_delimiter = environment.y
...Would that allow this to get merged immediately as a bugfix instead of a breaking change? |
|
Was this addressed with merge of #1997 ? |
|
Yes, I think we can close this pull request. Sorry for the late response. |
Addresses #1736.
Based on the bugfix by @liortct in #1767 but using the organization name throughout the project.