Skip to content

fixing badge display problem#1798

Merged
jensens merged 4 commits intocookiecutter:mainfrom
Paulokim1:README_correction
Jun 12, 2023
Merged

fixing badge display problem#1798
jensens merged 4 commits intocookiecutter:mainfrom
Paulokim1:README_correction

Conversation

@Paulokim1
Copy link
Copy Markdown
Contributor

@Paulokim1 Paulokim1 commented Nov 29, 2022

As shown below, the ['Build Status'] badge doens't show up, due to wrong reference to the tests.yml file.

image

I've changed the README.md file, referencing the appropriate path. With the change, the badge appears correctly as shown below.

image

@liortct
Copy link
Copy Markdown
Contributor

liortct commented Jan 12, 2023

Hi @Paulokim1 ,

We started working on a new community fork of the Cookiecutter project, named Cookieninja.
The fork is found at: https://github.com/cookieninja-generator/cookieninja

This PR is already solved. See: https://github.com/cookieninja-generator/cookieninja#readme

We're trying to bring the life back to this amazing project.
We are committed to reviewing and merging each PR in up to 2 weeks from the day it's opened (if there are no issues with it).
We'd really like you to join the fork, star it and contribute to it!

Thank you :)

kurtmckee
kurtmckee approved these changes Jun 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@audreyfeldroy @pydanny @jensens Please merge this PR.

It resolves an outstanding issue with the badge in the README, and can be viewed both in the author's screenshot as well as in their branch's README.

@jensens jensens added the documentation This issue/PR relates to or includes documentation. label Jun 12, 2023
@jensens jensens merged commit 5be63bb into cookiecutter:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jensens jensens jensens approved these changes

+1 more reviewer

@kurtmckee kurtmckee kurtmckee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation This issue/PR relates to or includes documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Paulokim1 @liortct @kurtmckee @jensens