Fixing Carriage Return Line Feed (CRLF) order in docs #1792#1793
Merged
jensens merged 2 commits intocookiecutter:mainfrom Jun 12, 2023
Merged
Fixing Carriage Return Line Feed (CRLF) order in docs #1792#1793jensens merged 2 commits intocookiecutter:mainfrom
jensens merged 2 commits intocookiecutter:mainfrom
Conversation
|
Hi @Lahiry We started working on a new community fork of the Cookiecutter project, named Cookieninja. We have re-opened and merged your PR in the Cookieninja project at: cookieninja-generator/cookieninja#29 We're trying to bring the life back to this amazing project. Thank you :) |
jensens
approved these changes
Jun 9, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the "Working with line-ends special symbols LF/CRLF" section of the documentation we can see:
The special template variable
_new_linesenforces a specific line ending. Acceptable variables:'\n\r'for CRLF and'\n'for POSIX.Here is example how to force line endings to CRLF on any deployment:
But this order is mistaken, since:
"The traditional order, when both control characters are used, is Carriage Return, then Line Feed.
The reason for this goes back to the old ASR-33 Teletype.
When a Carriage Return is issued to an ASR-33, the print head, if it is near the right margin, takes over a tenth of a second to return to the left margin, plus there is a bit of "bounce" when the left margin is hit.
If the order were Line Feed, then Carriage Return, the first printed character might occur a tenth of a second after the Carriage Return, and thus might end up printing (as a smear) halfway across the page. But if Line Feed comes after Carriage Return then the time taken by the Line Feed provides extra time for the print head to complete it's trip."
StackOverflow
So this PR aims at fixing the CRLF order to the traditional
'\r\n'