Added timeout on request.get() for ensuring that if a recipient serve…#1772
Merged
ericof merged 3 commits intocookiecutter:mainfrom Jun 13, 2023
Merged
Added timeout on request.get() for ensuring that if a recipient serve…#1772ericof merged 3 commits intocookiecutter:mainfrom
ericof merged 3 commits intocookiecutter:mainfrom
Conversation
…r is unavilabe then the application making request will not stall indefinitely
kurtmckee
suggested changes
Jun 10, 2023
Member
kurtmckee
left a comment
There was a problem hiding this comment.
Please remove the extraneous comment. The comment is too long and no advertisement is needed here.
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
ericof
approved these changes
Jun 13, 2023
Member
ericof
left a comment
There was a problem hiding this comment.
LGTM, thanks @openrefactory for contributing to cookiecutter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have detected this issue on branch
mainofcokkiecutterproject on the version with commit hashe9b3b8. This issue can be addressed as a api usage issue.Fixes for api usage issue:
In file:
cookiecutter/zipfile.py, methodunzipa request is made without a timeout parameter. If the recipient server is unavailable to service the request, application making the request may stall indefinitely. our intelligent code repair system iCR suggested that a timeout value should be specified.This issue was detected by our OpenRefactory's Intelligent Code Repair (iCR). We are running iCR on libraries in the
PyPIrepository to identify issues and fix them. You will get more info at: pypi.openrefactory.com