Code quality: utils.make_sure_path_exists refactored and type annotated#1722
Merged
Code quality: utils.make_sure_path_exists refactored and type annotated#1722
Conversation
…ake_sure_path_exists
jensens
previously approved these changes
Jun 9, 2022
Contributor
jensens
left a comment
There was a problem hiding this comment.
LGTM, just a minor idea how to phrase the log better.
Co-authored-by: Jens W. Klein <jk@kleinundpartner.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #1403
I checked usage of
make_sure_path_existsfunction, as one of the function related to files modification. First thought was to remove it, as it is almost wrapper over basic functions. But I decided to leave it with correct exception text, but without return.Type annotate for functions that use
make_sure_path_existsfor correct values passing.