Code quality: Tests upgrade: Use pathlib for files read/write#1718
Merged
Code quality: Tests upgrade: Use pathlib for files read/write#1718
Conversation
…ender_override.py)
…s_existing_cookiecutter.py)
…s_existing_cookiecutter.py)
alkatar21
reviewed
Jun 8, 2022
…ender_override.py)
insspb
commented
Jun 8, 2022
alkatar21
suggested changes
Jun 8, 2022
Contributor
alkatar21
left a comment
There was a problem hiding this comment.
open() and Path().open() should always be closed, preferably with a context manager, otherwise there will be open file handles. This does not change with pathlib. There are more places, which I have not marked. (The methods like read_text take care of it themselves, but open does not.)
tests/repository/test_determine_repo_dir_finds_existing_cookiecutter.py
Outdated
Show resolved
Hide resolved
tests/repository/test_determine_repo_dir_finds_subdirectories.py
Outdated
Show resolved
Hide resolved
…g_cookiecutter.py) Co-authored-by: alkatar21 <61387986+alkatar21@users.noreply.github.com>
…ctories.py) Co-authored-by: alkatar21 <61387986+alkatar21@users.noreply.github.com>
alkatar21
approved these changes
Jun 8, 2022
Contributor
alkatar21
left a comment
There was a problem hiding this comment.
Looks ok at first glance now.
jensens
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #1403
This PR include only file operation replace in tests, not covering all scope of #1403
This is done to be focused and for easy review. Other PR related to #1403 will be soon.