test_generate_file_verbose_template_syntax_error fixed#1671
Merged
jensens merged 3 commits intocookiecutter:masterfrom May 29, 2022
Merged
test_generate_file_verbose_template_syntax_error fixed#1671jensens merged 3 commits intocookiecutter:masterfrom
jensens merged 3 commits intocookiecutter:masterfrom
Conversation
Fixes cookiecutter#1655 - relative path that comes directly from Jinja2 TemplateSyntaxError in some cases is in format "./tests/..." in other "tests/... now both cases are accepted as a valid outcome.
att14
approved these changes
May 7, 2022
jurgenwigg
reviewed
May 16, 2022
Co-authored-by: jurgenwigg <53076001+jurgenwigg@users.noreply.github.com>
jurgenwigg
suggested changes
May 16, 2022
Contributor
jurgenwigg
left a comment
There was a problem hiding this comment.
Please also fix lint issues.
jurgenwigg
approved these changes
May 16, 2022
Contributor
Author
|
In general the |
Contributor
|
Green CI is always good idea :) Thanks for fixing CI |
Contributor
Author
|
Glad I could help - thank you for the review :) - it's helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1655 - relative path that comes directly from Jinja2 TemplateSyntaxError
in some cases is in format "./tests/..." in other "tests/... now both cases
are accepted as a valid outcome.