Skip to content

Added: Boolean variable support in JSON#1626

Merged
insspb merged 3 commits intocookiecutter:masterfrom
liortct:add-boolean-field
Jun 6, 2022
Merged

Added: Boolean variable support in JSON#1626
insspb merged 3 commits intocookiecutter:masterfrom
liortct:add-boolean-field

Conversation

@liortct
Copy link
Copy Markdown
Contributor

@liortct liortct commented Dec 19, 2021 •
edited by insspb
Loading

Added support for specifying boolean parameters inside cookiecutter.json, prompt for them and parse them as actual booleans.

Closes #1625

insspb
insspb approved these changes Jun 6, 2022
View reviewed changes
@insspb insspb force-pushed the add-boolean-field branch from 3513cbd to 768bfcf Compare June 6, 2022 10:39
@insspb
Copy link
Copy Markdown
Member

insspb commented Jun 6, 2022

rebased

@insspb insspb changed the title Add boolean variable support Added: Boolean variable support in JSON Jun 6, 2022
@insspb insspb added the feature This issue/PR relates to major feature request. label Jun 6, 2022
@insspb
Copy link
Copy Markdown
Member

insspb commented Jun 6, 2022

@liortct thank you for contribution and long merge waiting.

@insspb insspb merged commit 01b6e4d into cookiecutter:master Jun 6, 2022
@liortct
Copy link
Copy Markdown
Contributor Author

liortct commented Jun 6, 2022 •
edited
Loading

contribution

@liortct thank you for contribution and long merge waiting.

@insspb
I couldn't find a content details but I would like to help more in the project. I am interested in becoming more involved in the project and helping you guys.
I will be happy to hear where you need help, review on PR's, new fixtures, help with issues etc...
Feel free to contact me via liortct@gmail.com
Thanks

@alkatar21 alkatar21 mentioned this pull request Jun 13, 2022
Closed
@liortct liortct mentioned this pull request Aug 24, 2022
Closed
@eruber eruber mentioned this pull request Feb 5, 2023
Open
@xmnlab
Copy link
Copy Markdown

xmnlab commented Jun 9, 2023

sorry for commenting in a PR so old but just a feedback about using it from the CLI with --no-input
I am trying to use it with a bunch of options (1, yes, True, true) .. but it is not working properly :(
any advice would be very helpful

@browniebroke
Copy link
Copy Markdown
Member

browniebroke commented Jun 9, 2023

This change is not released to PyPI yet: 2.1.1...main

If you want to use it, you need to install the cookiecutter CLI from git

@xmnlab
Copy link
Copy Markdown

xmnlab commented Jun 9, 2023

Oh I see. Thanks for the information. Appreciate that.

Btw, is there any plan for cutting a new release?

@rmartin16 rmartin16 mentioned this pull request Jul 7, 2023
Closed
@liortct liortct mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@insspb insspb insspb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature This issue/PR relates to major feature request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Boolean parameters parsed as String

4 participants

@liortct @insspb @xmnlab @browniebroke