Add missing contributors#1535
Merged
simobasso merged 1 commit intocookiecutter:masterfrom Apr 26, 2021
Merged
Conversation
Those contributors were found using Github's `/repos/{owner}/{repo}/contributors` API
service. They were checked one by one to see if their contribution was worthy of mention
in the authors file: template links and minor fixes (check
cookiecutter#1243 (comment)) were not
considered.
Closes cookiecutter#1534
sambhav
approved these changes
Apr 26, 2021
Member
|
lol, @glumia I usually don't mind adding my name in the authors.md file. But thanks 👏 ! I think is really important to say "thank you" in some way in a project like this. |
simobasso
approved these changes
Apr 26, 2021
Contributor
Author
|
Yeah, me too, that's exactly why opened the issue and worked on it in the first place. Being grateful to people who contribute to cookiecutter in their free time is the least we can do! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1534
Those contributors were found using Github's
/repos/{owner}/{repo}/contributorsAPI service.They were checked one by one to see if their contribution was worthy of mention in the authors file: template links and minor* fixes (check #1243 (comment)) were not considered.
*Minor fixes <==> The kind of pull requests you see on Github when it's time of hacktoberfest