Merged
Conversation
simobasso
requested changes
Apr 22, 2021
Member
simobasso
left a comment
There was a problem hiding this comment.
Thanks @glumia welcome on board!
I just reviewed your pr and I added a small comment about #1528 (comment).
- Templates are not added to the `README.md` file anymore (check c73ce79). - Python 2 support was already dropped. - Debian and Ubuntu are just two specific linux distros, not a platform. Relates to cookiecutter#1528
simobasso
approved these changes
Apr 26, 2021
Member
|
Thanks @glumia I'm going to merge this one 🎉 ! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1528
I don't really like to add another file ((checklist changes moved to a separate PR)PR_CHECKLIST.md) to project's root directory but there's no other way to make the links in theCONTRIBUTING.mdfile work both on Github and in the compiled docs.