Skip to content

Coverage 100%#1526

Merged
simobasso merged 3 commits intocookiecutter:masterfrom
SharpEdgeMarshall:housekeeping_tests
Apr 22, 2021
Merged

Coverage 100%#1526
simobasso merged 3 commits intocookiecutter:masterfrom
SharpEdgeMarshall:housekeeping_tests

Conversation

@SharpEdgeMarshall
Copy link
Copy Markdown
Contributor

@SharpEdgeMarshall SharpEdgeMarshall commented Apr 20, 2021

Closes #1524

This PR:

  • Removes fix that skips some tests, used for old pypy3 version on Travis
  • Adds test for force_delete utils function
  • Adds unit test for OSError not thrown on windows
  • Adds fail-under 100% coverage

@SharpEdgeMarshall SharpEdgeMarshall changed the title Clean tests Coverage 100% Apr 22, 2021
Copy link
Copy Markdown
Contributor

@glumia glumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Member

@simobasso simobasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simobasso simobasso merged commit 43b8da6 into cookiecutter:master Apr 22, 2021
@SharpEdgeMarshall SharpEdgeMarshall added the CI/CD This issue/PR relates to the project CI/CD update or fix. label May 5, 2021
@simobasso simobasso mentioned this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD This issue/PR relates to the project CI/CD update or fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce the minimal coverage to 100%

3 participants