Renamed cookiecutter.package to API#1442
Merged
ssbarnea merged 2 commits intocookiecutter:masterfrom Aug 15, 2020
usneil:cookiecutterpkg-rename-doc2-0
Merged
Renamed cookiecutter.package to API#1442ssbarnea merged 2 commits intocookiecutter:masterfrom usneil:cookiecutterpkg-rename-doc2-0
ssbarnea merged 2 commits intocookiecutter:masterfrom
usneil:cookiecutterpkg-rename-doc2-0
Conversation
ssbarnea
requested changes
Aug 15, 2020
Member
ssbarnea
left a comment
There was a problem hiding this comment.
I am pretty sure this should have not passed CI as its it required for the title line to match the text length.
Clearly we missed to lint this.
matching line with its corresponding text length
Contributor
Author
|
right, maybe the CI test missed it. I have updated the line length, hope it suffices. Thanks for notifying @ssbarnea |
Member
|
It was never checked, I proposed a PR to fix few minutes ago. There were few issues I uncovered. |
Contributor
Author
|
got it. so would this PR be sufficient to close issue #1410? |
ssbarnea
approved these changes
Aug 15, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1410