Conversation
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Synck fork with Cookiecutter
Member
Author
|
To do:
|
pombredanne
reviewed
May 27, 2020
pombredanne
approved these changes
May 27, 2020
Contributor
pombredanne
left a comment
There was a problem hiding this comment.
Thank you for picking this up!
9aae5e9 to
8f1dc9e
Compare
|
Code Climate has analyzed commit a34df66 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.7% (0.0% change). View more on Code Climate. |
ssbarnea
approved these changes
May 28, 2020
8 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is based on two old PRs #406 and #1159 and solve problem from issue #405
What changed:
After this PR merged cookiecutter will detect new-line symbol on each file in template and will use same new-line as in template, no matter on what system is deployed.
For template developers we introduce special key
_new_linesthat allow to force new line character on deployment. (check included docs).This can break some old templates, that why marked as breaking change.
Some related tests refactored in style described in #1403 and #1405