Skip to content

Tests refactoring: test_utils write issues fixed #1405#1406

Merged
ssbarnea merged 1 commit intomasterfrom
tmpdir
May 27, 2020
Merged

Tests refactoring: test_utils write issues fixed #1405#1406
ssbarnea merged 1 commit intomasterfrom
tmpdir

Conversation

@insspb
Copy link
Copy Markdown
Member

@insspb insspb commented May 26, 2020

  • Monkeypatching instead of "possible to fail values"
  • tmpdir -> tmp_path
  • os -> pathlib

related #1405

@insspb insspb added the enhancement This issue/PR relates to a feature request. label May 26, 2020
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 89bd5f5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.5% (0.0% change).

View more on Code Climate.

@insspb insspb added code style This issue/PR relates to the project code style modification needs-review PR Only: This PR require review from other developer labels May 26, 2020
@insspb insspb self-assigned this May 26, 2020
@ssbarnea ssbarnea merged commit 0347a62 into master May 27, 2020
@ssbarnea ssbarnea deleted the tmpdir branch May 27, 2020 08:58
@insspb insspb added this to the 2.0.0 milestone May 27, 2020
@simobasso simobasso mentioned this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code style This issue/PR relates to the project code style modification enhancement This issue/PR relates to a feature request. needs-review PR Only: This PR require review from other developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants