Skip to content

Removed: Bumpversion, setup.py arguments.#1404

Merged
ssbarnea merged 2 commits intomasterfrom
bumpversion_removal
May 27, 2020
Merged

Removed: Bumpversion, setup.py arguments.#1404
ssbarnea merged 2 commits intomasterfrom
bumpversion_removal

Conversation

@insspb
Copy link
Copy Markdown
Member

@insspb insspb commented May 26, 2020

@insspb insspb added code style This issue/PR relates to the project code style modification deprecated Feature or component marked as deprecated and will be removed labels May 26, 2020
@insspb insspb self-assigned this May 26, 2020
@insspb insspb added the needs-review PR Only: This PR require review from other developer label May 26, 2020
Copy link
Copy Markdown
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good step towards obliterating setup.py, adopting setuptools-scm and PEP-518.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 2102863 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.5% (0.0% change).

View more on Code Climate.

@ssbarnea ssbarnea merged commit 93a3aa3 into master May 27, 2020
@ssbarnea ssbarnea deleted the bumpversion_removal branch May 27, 2020 09:24
@insspb insspb added this to the 2.0.0 milestone May 27, 2020
@simobasso simobasso mentioned this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code style This issue/PR relates to the project code style modification deprecated Feature or component marked as deprecated and will be removed needs-review PR Only: This PR require review from other developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants