Skip to content

Prevent duplication of text avatar into display name#3530

Merged
jcbrand merged 3 commits intomasterfrom
BetaRays/unbookmarked-name-duplication-fix
Nov 12, 2024
Merged

Prevent duplication of text avatar into display name#3530
jcbrand merged 3 commits intomasterfrom
BetaRays/unbookmarked-name-duplication-fix

Conversation

@BetaRays
Copy link
Contributor

@BetaRays BetaRays commented Oct 20, 2024

Fixes #3529.

  • Add a changelog entry for your change in CHANGES.md
  • When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.

@BetaRays
Copy link
Contributor Author

I tried making a test for it, but I’m not sure how to wait until the name has been updated, if it’s supposed to not change.

@BetaRays
Copy link
Contributor Author

BetaRays commented Oct 20, 2024

Also, I’m not sure if adding an entry to the changelog is necessary here if the bug didn’t appear in the previous version (or any released version). (The bug is also triggered by unread indicators.)

@BetaRays BetaRays force-pushed the BetaRays/unbookmarked-name-duplication-fix branch from 7c1e4ab to a09213e Compare October 25, 2024 09:37
This also seems to affect previous versions.
@jcbrand
Copy link
Member

jcbrand commented Nov 8, 2024

I tried making a test for it, but I’m not sure how to wait until the name has been updated, if it’s supposed to not change.

Maybe just look for an existing test in the roomslist plugin and add a check that the name stays the same when clicking on the item in the list to open a room.

@BetaRays
Copy link
Contributor Author

I tried making a test for it, but I’m not sure how to wait until the name has been updated, if it’s supposed to not change.

Maybe just look for an existing test in the roomslist plugin and add a check that the name stays the same when clicking on the item in the list to open a room.

My issue is that I need to put some kind of delay between clicking and checking for the new name (otherwise the test passes when it shouldn’t because the name hasn’t been updated yet): this is usually done with u.waitUntil but I’m not sure what condition to use (waiting for the name to change would fail if it stays the same as it’s supposed to).

@jcbrand jcbrand marked this pull request as ready for review November 12, 2024 09:55
@jcbrand
Copy link
Member

jcbrand commented Nov 12, 2024

My issue is that I need to put some kind of delay between clicking and checking for the new name (otherwise the test passes when it shouldn’t because the name hasn’t been updated yet): this is usually done with u.waitUntil but I’m not sure what condition to use (waiting for the name to change would fail if it stays the same as it’s supposed to).

You could set a different name before clicking and then checking that it is set back to the right name, but I don't think a test is that important in this case, so I'll merge.

@jcbrand jcbrand merged commit 6c22a90 into master Nov 12, 2024
@jcbrand jcbrand deleted the BetaRays/unbookmarked-name-duplication-fix branch February 17, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on unbookmarked rooms with automatic "letters" avatar duplicates it into room title

2 participants