Skip to content

Busy-loop when fetching registration form fails #1490

@weiss

Description

@weiss

At least with a registration_domain specified, Converse.js busy-loops when requesting a registration form and the server responds with e.g. the following error:

<iq xml:lang='en' from='example.com' type='error' id='d9917b7a-588f-4ef6-8a56-0d6d3ad538ae:sendIQ'>
  <query xmlns='jabber:iq:register'/>
  <error code='500' type='wait'>
    <resource-constraint xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
    <text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Too many CAPTCHA requests</text>
  </error>
</iq>

It spits out ERROR: Problem during registration: Strophe.Status is REGIFAIL.

Even though the error is of type='wait', I think it would be better to just abort the request and display the error message.

(Can easily be reproduced by setting registration_domain: 'conversations.im' and reloading the registration dialog a few times.)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions