chore: pre pnpm cleanup#4759
Merged
Merged
Conversation
conventional-commits-parser v6 ships its own type definitions (see exports.types in its package.json), so the DefinitelyTyped @types/conventional-commits-parser package is shadowed and adds no value. Remove it from the four packages that still list it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Seven packages import from node:* modules (node:module, node:util, node:readline, node:fs, node:os, node:path, node:url, node:child_process, node:process) but rely on yarn's hoisting to resolve @types/node. Declare it explicitly so the dependency is honest and the packages build under any package manager. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@commitlint/prompt's InputCustomPrompt imports type Subscription from "rxjs" but does not declare rxjs in its package.json. The package resolves today only because inquirer transitively pulls it in and yarn hoists it. Declare it explicitly to make the dependency honest. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@commitlint/cli imports type ParserOptions from "conventional-commits-parser" but does not declare the package. It resolves today only because @commitlint/types lists it as a runtime dep and yarn hoists it. Declare it explicitly as a devDependency (type-only import). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The root vitest config sets environment: "commitlint", which loads vitest-environment-commitlint (the workspace package at @packages/test-environment). Declare it at root so the dependency is honest and resolves under any package manager, not only via yarn's workspace hoisting. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The root commitlint.extends list references @commitlint/config-conventional and @commitlint/config-workspace-scopes, but neither is declared in the root devDependencies. They resolve today only because yarn workspaces hoist them. Declare them explicitly so the root config is self-contained. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the repo for a pnpm-oriented dependency layout by making TypeScript/runtime dependency declarations more explicit across workspaces (and removing now-redundant types packages).
Changes:
- Removed
@types/conventional-commits-parserusage/lockfile entry (parser v6 provides its own types). - Added
@types/nodeto several workspace packages that importnode:*modules. - Added missing dev deps used for type imports/tests/config (
rxjs,conventional-commits-parser,vitest-environment-commitlint, and root commitlint configs).
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes the now-unused @types/conventional-commits-parser resolution entry. |
| package.json | Adds root devDeps for commitlint configs and vitest-environment-commitlint. |
| @commitlint/types/package.json | Drops @types/conventional-commits-parser devDep (types come from conventional-commits-parser). |
| @commitlint/travis-cli/package.json | Adds @types/node devDep for Node ESM imports/types usage. |
| @commitlint/top-level/package.json | Adds @types/node devDep for Node ESM imports/types usage. |
| @commitlint/rules/package.json | Replaces @types/conventional-commits-parser with @types/node in devDeps. |
| @commitlint/resolve-extends/package.json | Adds @types/node devDep for Node ESM imports/types usage. |
| @commitlint/prompt/package.json | Adds @types/node and rxjs devDeps for type-only imports. |
| @commitlint/parse/package.json | Drops @types/conventional-commits-parser devDep (parser v6 types). |
| @commitlint/lint/package.json | Adds @types/node devDep for Node ESM imports/types usage. |
| @commitlint/config-validator/package.json | Adds @types/node devDep for Node ESM imports/types usage. |
| @commitlint/cli/package.json | Adds conventional-commits-parser devDep to satisfy type-only import resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.