Skip to content

fix: fallback to resolve-from for Yarn P'n'P#3941

Merged
escapedcat merged 2 commits intoconventional-changelog:masterfrom
JounQin:fix/pnp_esm
Feb 28, 2024
Merged

fix: fallback to resolve-from for Yarn P'n'P#3941
escapedcat merged 2 commits intoconventional-changelog:masterfrom
JounQin:fix/pnp_esm

Conversation

@JounQin
Copy link
Copy Markdown
Collaborator

@JounQin JounQin commented Feb 28, 2024

Description

close #3936

Motivation and Context

This is only a workaround for Yarn P'n'P + pure ESM, but it's also good enough.

We'll still watch wooorm/import-meta-resolve#23

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JounQin JounQin changed the title fix: fallback to for Yarn P'n'P fix: fallback to require.resolve for Yarn P'n'P Feb 28, 2024
@JounQin JounQin changed the title fix: fallback to require.resolve for Yarn P'n'P fix: fallback to resolve-from for Yarn P'n'P Feb 28, 2024
This was referenced Feb 28, 2024
Closed
Merged
escapedcat
escapedcat reviewed Feb 28, 2024
View reviewed changes
@commitlint/resolve-extends/src/index.ts
throw resolveError;
try {
/**
* Yarn P'n'P does not support pure ESM well, this is only a workaround for
Copy link
Copy Markdown
Member

@escapedcat escapedcat Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're not the only project breaking yarn p'n'p projects with a new major version

@escapedcat escapedcat merged commit 1eb9b5f into conventional-changelog:master Feb 28, 2024
@JounQin JounQin deleted the fix/pnp_esm branch February 28, 2024 10:41
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@escapedcat escapedcat escapedcat left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v19 gives @commitlint/config-conventional with yarn pnp

2 participants

@JounQin @escapedcat