Skip to content

fix: detect esmodule project#3773

Closed
pfdgithub wants to merge 1 commit intoconventional-changelog:masterfrom
pfdgithub:fix-issue-3768
Closed

fix: detect esmodule project#3773
pfdgithub wants to merge 1 commit intoconventional-changelog:masterfrom
pfdgithub:fix-issue-3768

Conversation

@pfdgithub
Copy link

@pfdgithub pfdgithub commented Nov 13, 2023

Description

fix #3768
I'm not sure why you want to override the default js dynamic loader, so I just kept the default js dynamic loader in the esmodule project.

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joberstein
Copy link
Contributor

joberstein commented Nov 13, 2023

I'd like to look into this a little more; node 20.8 fixed a memory leak that was happening with dynamic imports, and the JS sync loader should've been the default in the previous commitment/load version.

@joberstein joberstein mentioned this pull request Nov 16, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

2 participants

@pfdgithub @joberstein