Skip to content

chore!: minimum node version v18#3644

Merged
escapedcat merged 8 commits intomasterfrom
feat/minimum-node-version-18
Oct 20, 2023
Merged

chore!: minimum node version v18#3644
escapedcat merged 8 commits intomasterfrom
feat/minimum-node-version-18

Conversation

@escapedcat
Copy link
Copy Markdown
Member

@escapedcat escapedcat commented Aug 19, 2023 •
edited
Loading

BREAKING CHANGE: drop node v14 and v16 support

v16 is almost EOL as well: https://github.com/nodejs/release#release-schedule

This will be merged in September 2023.
#3633 can be re-applied after. @joberstein wdyt?

  • remove TS v4 support (here and in other places?)

@escapedcat escapedcat force-pushed the feat/minimum-node-version-18 branch 2 times, most recently from 07e8e23 to 2c11d37 Compare August 19, 2023 06:52
@joberstein
Copy link
Copy Markdown
Contributor

joberstein commented Aug 28, 2023

@escapedcat sounds good to me, the only thing I want to call out is with my pull request that I also updated @types/node, but it was to a lesser version than what's bumped up here. Just want to make sure this version bump wins when my pull request changes are re-applied.

@escapedcat
Copy link
Copy Markdown
Member Author

escapedcat commented Aug 28, 2023

@escapedcat sounds good to me, the only thing I want to call out is with my pull request that I also updated @types/node, but it was to a lesser version than what's bumped up here. Just want to make sure this version bump wins when my pull request changes are re-applied.

Thanks for the heads up. Good point.

@escapedcat escapedcat force-pushed the feat/minimum-node-version-18 branch from 14cb9ea to 6bd4f64 Compare September 12, 2023 14:43
@escapedcat escapedcat marked this pull request as ready for review September 12, 2023 14:58
This was referenced Sep 27, 2023
Merged
Closed
@joberstein
Copy link
Copy Markdown
Contributor

joberstein commented Oct 1, 2023

@escapedcat is this still ready to merge?

AdeAttwood
AdeAttwood requested changes Oct 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@AdeAttwood AdeAttwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a couple of questions, also have we checked the docker images build. I think it could be worth a rebase to test that build.

@escapedcat
Copy link
Copy Markdown
Member Author

escapedcat commented Oct 2, 2023

@escapedcat is this still ready to merge?

Yeah, will take a look within the next days. Bit busy currently.

@escapedcat
Copy link
Copy Markdown
Member Author

escapedcat commented Oct 8, 2023 •
edited
Loading

If possible, also add: #3690
Leading to failing tests

@escapedcat escapedcat mentioned this pull request Oct 19, 2023
Closed
4 tasks
@escapedcat escapedcat force-pushed the feat/minimum-node-version-18 branch from 51bd34d to 32a513d Compare October 20, 2023 12:16
@escapedcat escapedcat merged commit 5b4aeaf into master Oct 20, 2023
@escapedcat escapedcat deleted the feat/minimum-node-version-18 branch October 20, 2023 13:18
@escapedcat escapedcat mentioned this pull request Oct 20, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdeAttwood AdeAttwood AdeAttwood requested changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@escapedcat @joberstein @AdeAttwood