Skip to content

feat: [scope-enum] [scope-case] allow space after comma as scope delimiter#3577

Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom
miluoshi:patch-1
Oct 25, 2023
Merged

feat: [scope-enum] [scope-case] allow space after comma as scope delimiter#3577
escapedcat merged 1 commit intoconventional-changelog:masterfrom
miluoshi:patch-1

Conversation

@miluoshi
Copy link
Copy Markdown
Contributor

@miluoshi miluoshi commented Apr 4, 2023

fixes #3576

Description

See #3576

Usage examples

// commitlint.config.js
module.exports = {
  'scope-enum': [2, 'always', ['foo', 'baz']],
};
echo "type(foo, baz): subject" | commitlint # passes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Copy Markdown
Member

@miluoshi
Copy link
Copy Markdown
Contributor Author

miluoshi commented Apr 4, 2023

My bad. I've used never instead of always in the new test. Now it should be fixed

@escapedcat
Copy link
Copy Markdown
Member

@miluoshi sorry, wanna rebase this? Will merge if it turns 🟢

@miluoshi
Copy link
Copy Markdown
Contributor Author

@escapedcat rebased ✅

@escapedcat escapedcat merged commit 13c4bfc into conventional-changelog:master Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

feat: [scope-enum] [scope-case] allow space after comma as scope delimiter

2 participants