feat(version): allows bumping a prerelease version#105
Merged
hdevalke merged 1 commit intoconvco:masterfrom Jan 23, 2023
Merged
feat(version): allows bumping a prerelease version#105hdevalke merged 1 commit intoconvco:masterfrom
hdevalke merged 1 commit intoconvco:masterfrom
Conversation
hdevalke
reviewed
Jan 23, 2023
Collaborator
hdevalke
left a comment
There was a problem hiding this comment.
Thank you for the PR.
I will have a look at it more in detail later.
src/cli.rs
Outdated
| pub patch: bool, | ||
| /// Suffix with a prerelease version. Only works in combination with bump | ||
| #[clap(long, default_value = "")] | ||
| pub prerelease: String, |
Collaborator
There was a problem hiding this comment.
maybe it is good to use semver::Prerelease.
This will validate the command line argument
When prerelease is given as a parameter with the value 'beta', the version would look like: x.y.z-beta.1 Fixes: #90 Signed-off-by: Jan van den Berg <koozz@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When prerelease is given as a parameter with the value 'beta', the version would look like:
x.y.z-beta.1, if this tag is present, the next bump would bex.y.z-beta.2.Fixes: #90