fix: div by zero in SegmentedBar#1601
Merged
abhinayagarwal merged 3 commits intoOct 31, 2025
Merged
Conversation
added 3 commits
October 27, 2025 11:42
(cherry picked from commit 30e7459)
|
Hi jixxed, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
danielpeintner
approved these changes
Oct 30, 2025
danielpeintner
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Didn't run the tests but simply looking at your code the change makes sense and should avoid div by zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1589
A total of 0 results in a NaN due to a division by 0 and consequently results in the high CPU load described in #1589
This PR sets the segmentWidth or segmentHeight to 0 if the total is 0