Provide a public getter method for the Dialog used by a Wizard#1542
Merged
abhinayagarwal merged 3 commits intoMar 13, 2025
Merged
Conversation
|
Hi ianrenton, Welcome to ControlsFX and thank you for taking time to contribute to this project. We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ? |
Siedlerchr
approved these changes
Mar 27, 2024
Collaborator
|
Please adjust the copyright year in the header |
Siedlerchr
approved these changes
Jul 8, 2024
abhinayagarwal
approved these changes
Mar 12, 2025
Siedlerchr
approved these changes
Mar 13, 2025
This was referenced Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this provides the access necessary to resolve #756, #976, #999 and #1388.
I have chosen to make
getDialog()public rather than alternative methods such as asetDialog()or makingdialogitself protected as I believe this offers the simplest possible change to meet the needs of these issues (and my own).I can't see any obvious disadvantage to making the Wizard dialog accessible in this way, but if there is some subtlety that I have missed, please let me know.