Add NonlinearSolve comparision in Goddard tutorial#29
Merged
Conversation
Closed
jbcaillau
reviewed
Jul 2, 2025
Member
There was a problem hiding this comment.
hi @YouriRenoud Manifest.toml should not be synced on git
Member
There was a problem hiding this comment.
For this one, it is ok. It is the one that is used for reproducibility:
Lines 4 to 6 in a50c09c
Member
There was a problem hiding this comment.
However, the code that copy it should be replaced by:
# For reproducibility
mkpath(joinpath(@__DIR__, "src", "assets"))
cp(joinpath(@__DIR__, "Manifest.toml"), joinpath(@__DIR__, "src", "assets", "Manifest.toml"), force = true)
cp(joinpath(@__DIR__, "Project.toml"), joinpath(@__DIR__, "src", "assets", "Project.toml"), force = true)
Collaborator
Author
There was a problem hiding this comment.
So I need to change these line in make.jl ? @ocots
ocots
approved these changes
Jul 21, 2025
docs/src/tutorial-goddard.md
Outdated
| # NonlinearSolve resolution | ||
| nle_new!(s, ξ, p) = shoot!(s, ξ[1:3], ξ[4], ξ[5], ξ[6], ξ[7]) | ||
| prob_nls = NonlinearProblem(nle_new!, ξ) | ||
| sol_nls = solve(prob_nls; show_trace=Val(true)) |
Member
There was a problem hiding this comment.
@YouriRenoud I think that to see the trace, you need to split in two blocks.
Member
There was a problem hiding this comment.
Est-ce que tu vois
Algorithm: NewtonRaphson(
descent = NewtonDescent(),
autodiff = AutoForwardDiff(),
vjp_autodiff = AutoReverseDiff(
compile = false
),
jvp_autodiff = AutoForwardDiff(),
concrete_jac = Val{false}()
)
Member
|
Thanks @YouriRenoud ! I merge this PR and close the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.