Simplify parameter validation with compile-time type constraints#89
Merged
Simplify parameter validation with compile-time type constraints#89
Conversation
Replace runtime validation using _supported_parameters() and
validate_supported_parameter() with compile-time type constraints
directly in struct definitions.
Changes:
- Update struct definitions to use specific type constraints:
* CPU-only strategies: P<:CPU (ADNLP, Ipopt, Knitro)
* CPU+GPU strategies: P<:Union{CPU, GPU} (Exa, MadNLP, MadNCL)
- Remove _supported_parameters() and validate_supported_parameter() functions
- Remove validation calls from constructors and metadata() functions
- Update extensions to remove validation calls
- Update tests to expect TypeError instead of IncorrectArgument
- Remove tests for deleted validation functions
Benefits:
- ~150 lines of code removed
- Earlier error detection (compile-time vs runtime)
- Simpler and more robust validation mechanism
- Clearer intent with type constraints visible in struct definitions
All 2895 tests pass successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace runtime validation using _supported_parameters() and validate_supported_parameter() with compile-time type constraints directly in struct definitions.
Changes:
Benefits:
All 2895 tests pass successfully.