Conversation
- Update CTModels dependency from 0.8 to 0.9 - Replace AbstractOptimalControlProblem with AbstractModel in type definitions - Update documentation references to use new abstract types - Update test suite to use new AbstractModel interface
- Update type references in DOCP module files - Rename types in documentation (architecture.md, implementing_an_optimization_problem.md, index.md) - Update test suites to use new type names - Maintain consistency across all references
- Update Modelers module with new type references - Update Strategies API and contract files - Update Orchestration and Solvers modules - Update comprehensive test suites - Update documentation to reflect type changes - Maintain consistency across all module interfaces
- Update all references to ADNLPModeler to use Modelers.ADNLPModeler - Fix test imports to use explicit module qualification - Update documentation examples with proper module prefixes - Maintain consistency in module naming across all files - Fix isdefined syntax errors in test files
- Replace all occurrences of ADNLPModeler with ADNLP - Update struct definition from ADNLPModeler to ADNLP - Update constructor function name from Modelers.ADNLPModeler to Modelers.ADNLP - Update all documentation references and examples - Update all test files to use new type name - Update exports in Modelers module - Maintain backward compatibility through deprecation warnings
- Update all references to ExaModeler to use Modelers.ExaModeler - Maintain consistency with ADNLP qualification pattern - Update struct definition to use ExaModeler (not Modelers.ExaModeler) - Update all documentation references and examples - Update all test files to use qualified module names - Update imports in test files for consistency - Ensure uniform naming convention across both modelers
- Replace all occurrences of ExaModeler with Exa - Update struct definition from ExaModeler to Exa - Update constructor function name from Modelers.ExaModeler to Modelers.Exa - Update all documentation references and examples - Update all test files to use new type name - Update exports in Modelers module - Maintain consistent naming pattern with ADNLP (short, concise names) - Update cross-references between ADNLP and Exa documentation
- Add redirect_stderr(devnull) around tests that intentionally generate warnings - Hide warnings for unknown options in permissive mode tests - Keep test functionality while reducing terminal output pollution - Apply to Modelers.ADNLP, Modelers.Exa, and all solver tests - Maintain all test assertions and validation logic
- Wrap all permissive mode tests with redirect_stderr(devnull) to hide expected warnings - Wrap validation error tests with redirect_stderr(devnull) to hide expected error messages - Fix missing 'end' in test_strict_permissive_integration.jl - Comment out println statements for extension loading in test_route_to_comprehensive.jl Tests now have clean output while maintaining all validation logic.
- Rename IpoptSolver -> Ipopt for brevity and consistency - Rename KnitroSolver -> Knitro for brevity and consistency - Update all references in tests, documentation, and extensions - Maintain backward compatibility through proper exports - Update solver registry and validation tests - Fix all documentation references to use new names All tests pass with the new naming convention.
- Rename Solvers.MadNLPSolver to Solvers.MadNLP across codebase - Update all test files to use new naming convention - Fix import statements and references in documentation - Update CHANGELOG.md with breaking change notice - Ensure consistency in solver type naming This is a breaking change that affects user code using MadNLP solver.
- Suppress deprecation warnings in modelers tests using redirect_stderr - Fix import references in comprehensive validation tests - Remove console warnings for adnlp_backend and exa_backend aliases - Ensure clean test output while maintaining test logic
…onal typos ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames modelers and solvers to have more consistent and concise naming throughout the codebase.
Renamings
Modelers
DiscretizedOptimalControlProblem→DiscretizedModelAbstractOptimizationModeler→AbstractNLPModelerADNLPModeler→ADNLPExaModeler→ExaSolvers
AbstractOptimizationSolver→AbstractNLPSolverIpoptSolver→IpoptMadNLPSolver→MadNLPMadNCLSolver→MadNCLKnitroSolver→KnitroStrategy Framework (unchanged)
AbstractStrategyStrategyRegistryStrategyMetadataStrategyOptionsOptionDefinitionRoutedOptionChanges
Modelers.ADNLPinstead ofADNLPModeler)Files Modified
src/Modelers/- All modeler implementationssrc/Solvers/- All solver implementationstest/- Updated test referencesext/- Updated extension implementationsImpact