Conversation
- Add __time_grid_default_component() function returning :state - Update time_grid method signature for MultipleTimeGridModel with default parameter - Remove exception method that required explicit component specification - Update tests to verify new default behavior - Add test for new default function in test_defaults.jl - Update CHANGELOG.md and BREAKING.md for v0.9.12-beta - Maintain full backward compatibility with explicit component syntax time_grid(sol) now works consistently for both UnifiedTimeGridModel and MultipleTimeGridModel, defaulting to state grid for multi-grid solutions.
- Fix test_multi_grids.jl to expect T_state instead of exception - Update test to verify time_grid(sol) returns state grid by default - Ensure consistency with new MultipleTimeGridModel default behavior
Member
Author
|
Make then a new stable release when merged. |
Contributor
|
Breakage test results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
time_grid(sol) now works consistently for both UnifiedTimeGridModel and MultipleTimeGridModel, defaulting to state grid for multi-grid solutions.