Conversation
- Track which autonomous/variable arguments user explicitly provided - Add _get_TD and _get_VD accessor functions for type parameter extraction - Create __check_bracket_consistency function to validate operand compatibility - Always check TD/VD mismatches between typed operands - Only check user args against operands when explicitly provided - Update __transform_lie_poisson_expression to call consistency checks - Add 47 comprehensive test scenarios covering all TD/VD combinations - Fix test syntax errors with parentheses for macro + isa expressions Fixes issue where autonomous/variable keyword arguments were silently ignored when used with already typed VectorField/Hamiltonian operands.
- Updated Project.toml version to 0.8.19-beta - Added comprehensive changelog entry for Lie macro consistency checks - Documented all new features, changes, fixes, and test improvements
Contributor
|
Breakage test results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where autonomous/variable keyword arguments were silently ignored when used with already typed VectorField/Hamiltonian operands.