Conversation
Member
ocots
commented
Mar 26, 2026
- Extract __is_mixed_usage() function to detect mixed Lie/Poisson brackets
- Extract __parse_lie_args() function to parse keyword arguments
- Extract __transform_lie_poisson_expression() function to transform expressions
- Add comprehensive docstrings with examples for all helper functions
- Add 40+ new tests covering all helper functions and error cases
- Use CTBase.Exceptions.IncorrectArgument instead of ArgumentError
- Qualify function calls with CTFlows. to avoid namespace conflicts
- Simplify macro logic and improve maintainability
- All tests pass: 223/223
- Extract __is_mixed_usage() function to detect mixed Lie/Poisson brackets - Extract __parse_lie_args() function to parse keyword arguments - Extract __transform_lie_poisson_expression() function to transform expressions - Add comprehensive docstrings with examples for all helper functions - Add 40+ new tests covering all helper functions and error cases - Use CTBase.Exceptions.IncorrectArgument instead of ArgumentError - Qualify function calls with CTFlows. to avoid namespace conflicts - Simplify macro logic and improve maintainability - All tests pass: 223/223
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 94.35% 94.58% +0.22%
==========================================
Files 15 15
Lines 585 591 +6
==========================================
+ Hits 552 559 +7
+ Misses 33 32 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Breakage test results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.