Skip to content

444 bug exa solution post processing#451

Merged
PierreMartinon merged 10 commits intomainfrom
444-bug-exa-solution-post-processing
Jul 31, 2025
Merged

444 bug exa solution post processing#451
PierreMartinon merged 10 commits intomainfrom
444-bug-exa-solution-post-processing

Conversation

@jbcaillau
Copy link
Copy Markdown
Member

closes #444

@jbcaillau jbcaillau linked an issue Jul 28, 2025 that may be closed by this pull request
@jbcaillau jbcaillau requested a review from PierreMartinon July 28, 2025 20:40
@jbcaillau jbcaillau marked this pull request as ready for review July 28, 2025 20:41
@jbcaillau jbcaillau marked this pull request as draft July 28, 2025 20:41
@jbcaillau jbcaillau marked this pull request as ready for review July 28, 2025 20:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 28, 2025

Breakage test results
Date: 2025-07-29 16:29:55

Name Latest Stable
OptimalControl.jl compat: v0.15.2 compat: v0.14.10

@jbcaillau
Copy link
Copy Markdown
Member Author

@PierreMartinon please review this version (solution parsing fix only, init part under to be done)

NB: have you deactivated checks for draft PR in this repo?

@PierreMartinon
Copy link
Copy Markdown
Member

PierreMartinon commented Jul 30, 2025

Hi JB
One question: why did you change the build_nlp return from the nlp to the docp ?

NB: have you deactivated checks for draft PR in this repo?

I noticed the checks do not run for draft PRs, not sure this is voluntary :D
Is it different for CTParser ?

@jbcaillau
Copy link
Copy Markdown
Member Author

@PierreMartinon please review this version (solution parsing fix only, init part under to be done)

NB: have you deactivated checks for draft PR in this repo?

i needed to update docp to store the getter. since docp also has a field to store the nlp, in the end it is just a side effect on docp, hence build_nlp -> build_nlp!

@PierreMartinon PierreMartinon merged commit 5eece81 into main Jul 31, 2025
10 checks passed
@PierreMartinon PierreMartinon deleted the 444-bug-exa-solution-post-processing branch July 31, 2025 07:58
@jbcaillau
Copy link
Copy Markdown
Member Author

Hi JB One question: why did you change the build_nlp return from the nlp to the docp ?

NB: have you deactivated checks for draft PR in this repo?

I noticed the checks do not run for draft PRs, not sure this is voluntary :D Is it different for CTParser ?

yes, in CTParser (and other CTX repos), draft PR run checks. not a big deal though, also makes sense to wait for PR to run checks

@ocot any idea on this?

@jbcaillau
Copy link
Copy Markdown
Member Author

@PierreMartinon more important: post processing seems not to be completely OK 🙁 i am reopening #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Exa solution post processing

2 participants