Reduce unnecessary mentions#136
Merged
ibakshay merged 1 commit intocontributor-assistant:masterfrom Apr 14, 2023
wh201906:mentions
Merged
Reduce unnecessary mentions#136ibakshay merged 1 commit intocontributor-assistant:masterfrom wh201906:mentions
ibakshay merged 1 commit intocontributor-assistant:masterfrom
wh201906:mentions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there.
In the current code, both signed committers and unsigned committers will be mentioned when not all of the committers sign the CLA/DCO. This behavior brings a lot of unnecessary mentions for the signed committers. I think only unsigned committers should be mentioned.
In this PR. I replace the mentions to the signed committers with a link to their profile. Users can still click the link to access the users' profiles.