Skip to content

Pin matplotlib < 3.9.1 on Windows#406

Merged
ianthomas23 merged 1 commit intomainfrom
pin_mpl_windows
Jul 11, 2024
Merged

Pin matplotlib < 3.9.1 on Windows#406
ianthomas23 merged 1 commit intomainfrom
pin_mpl_windows

Conversation

@ianthomas23
Copy link
Copy Markdown
Member

@ianthomas23 ianthomas23 commented Jul 11, 2024

CI on Windows is failing with access violations when using Matplotlib 3.9.1 for testing, but with 3.9.0 it seems to be OK. This PR therefore pins Matplotlib to < 3.9.1 on Windows to confirm this.

@ianthomas23
Copy link
Copy Markdown
Member Author

ianthomas23 commented Jul 11, 2024

Here is the output of one of the failed CI runs:

=========================== short test summary info ===========================
FAILED tests/test_filled.py::test_filled_z_nonfinite[0.0-0.0--inf-serial]
FAILED tests/test_filled.py::test_filled_z_nonfinite[-inf-inf--inf-threaded]
FAILED tests/test_lines.py::test_multi_lines_invalid_levels[mpl2005-SeparateCode]
FAILED tests/test_z_interp.py::test_z_interp_negative[serial]
FAILED tests/test_lines.py::test_multi_lines_invalid_levels[mpl2014-SeparateCode]
FAILED tests/test_filled.py::test_filled_z_nonfinite[0.0-0.0-nan0-mpl2005]
=========== 6 failed, 2386 passed, 121 skipped in 247.93s (0:04:07) ===========

If you just run one of the tests that fails above then it passes, so this is something to do with dodgy state that results from a previous test.

@ianthomas23
Copy link
Copy Markdown
Member Author

ianthomas23 commented Jul 11, 2024

Here is the previous failing CI run on main branch: https://github.com/contourpy/contourpy/actions/runs/9893737840
And the successful CI run here: https://github.com/contourpy/contourpy/actions/runs/9894117595

@ianthomas23
Copy link
Copy Markdown
Member Author

ianthomas23 commented Jul 11, 2024

Merging so that CI is green, will investigate further.

@ianthomas23 ianthomas23 merged commit fc0e717 into main Jul 11, 2024
@ianthomas23 ianthomas23 deleted the pin_mpl_windows branch July 11, 2024 15:38
@ianthomas23 ianthomas23 mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ianthomas23