fix: merge yaml.schemas settings #9483
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
1 similar comment
Contributor
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
9d3e47a to
8790b8e
Compare
Contributor
Author
I don't think this error is related to my PR :/ |
Users may already have `yaml.schemas` preferences and the extension should not be overwriting user settings. The code is however free to control keys for `extensionUri`, as long as it leaves other entries alone. See also continuedev#7080
8790b8e to
a0729bd
Compare
RomneyDa
approved these changes
Jan 14, 2026
Contributor
|
🎉 This PR is included in version 1.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users may already have
yaml.schemaspreferences and the extension should not be overwriting user settings.The code is however free to control keys for
extensionUri, as long as it leaves other entries alone.See also #7080
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
N/A
Tests
N/A
Continue Tasks
Powered by Continue
Summary by cubic
Preserve user-defined yaml.schemas settings by merging instead of overwriting when registering the extension’s schema. The extension only adds/updates its own entry keyed by extensionUri and leaves other schema mappings unchanged.
Written for commit a0729bd. Summary will update on new commits.