Skip to content

Fix: MCP error output and bugfixes #8655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RomneyDa merged 3 commits into from
Nov 10, 2025
Merged

Fix: MCP error output and bugfixes #8655

RomneyDa merged 3 commits into from
Nov 10, 2025

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Nov 10, 2025 •
edited by cubic-dev-ai bot
Loading

Description

  • Adds stderr from MCP to MCP warnings, or errors if causes MCP loading to fail
  • Removes noisy log caused when loading markdown rules in the CLI
    Fixes issue with servers that don't implement every endpoint throwing errors in headless

Summary by cubic

Capture MCP server stderr and show it as warnings, adding stderr to error messages when a server fails to connect. Headless mode now only fails on connection errors, reducing false failures for servers that don’t implement every endpoint.

  • Bug Fixes
    • Pipe stdio stderr from MCP servers; collect as warnings and append to errors on connection failure.
    • Headless/agent init waits for connections and throws only on connection errors; stop throwing on missing prompts/tools.
    • Remove noisy config parse log from YAML unroll; quieter CLI output.
    • UI: add null/undefined guards in MCPSelector to prevent runtime errors.
    • Services: correct MCP state type usage and update initialize signature for headless/agent flags.

Written for commit 92e6c8a. Summary will update automatically on new commits.

RomneyDa and others added 2 commits November 9, 2025 18:22
@RomneyDa
feat: Says hi
63bd5dc 
Generated with [Continue](httpshttps://continue.dev)

Co-Authored-By: Continue <noreply@continue.dev>
@RomneyDa
fix: various mcp fixes and error/warnings
a79e28f
@RomneyDa RomneyDa requested a review from a team as a code owner November 10, 2025 02:40
@RomneyDa RomneyDa requested review from tingwai and removed request for a team November 10, 2025 02:40
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Nov 10, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Prompt for AI agents (all 1 issues) 

Understand the root cause of the following 1 issues and fix them.


<file name="extensions/cli/src/services/MCPService.ts">

<violation number="1" location="extensions/cli/src/services/MCPService.ts:107">
When agent mode waits for MCP connections it now ignores failures because the check only runs when isHeadless is true, so agent initialization can succeed with disconnected servers. Update the condition to include hasAgentFile as intended.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2025
@RomneyDa RomneyDa merged commit 16f02a2 into main Nov 10, 2025
58 checks passed
@RomneyDa RomneyDa deleted the dallin/mcp-fixes-stderr branch November 10, 2025 23:39
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Nov 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2025
@sestinj
Copy link
Contributor

sestinj commented Nov 18, 2025

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Nov 19, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Nov 20, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

+1 more reviewer

@tingwai tingwai tingwai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RomneyDa @sestinj @tingwai