Add x-continue-unique-id header to LLM requests and normalize header casing #8589
Conversation
|
|
✅ Review Complete Code Review Summary |
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="extensions/cli/src/telemetry/posthogService.ts">
<violation number="1" location="extensions/cli/src/telemetry/posthogService.ts:15">
Making uniqueId fully public allows outside code to rewrite it, which breaks the invariant that telemetry events share a stable distinctId. Please expose it as read-only instead of writable.</violation>
</file>
<file name="extensions/cli/src/config.ts">
<violation number="1" location="extensions/cli/src/config.ts:77">
Non-proxy LLM configs no longer merge in the telemetry headers, so the new user-agent/x-continue-unique-id values are now omitted for all providers except "continue-proxy". Please keep calling mergeUserAgentIntoRequestOptions here so every request includes the intended headers.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by cubic
Adds the x-continue-unique-id header to LLM requests and standardizes header casing to user-agent for reliable header merging. Also adds a safe proxyUrl fallback to env.apiBase when an on-prem proxy is not set.
New Features
Bug Fixes
Written for commit e47a6d5. Summary will update automatically on new commits.