feat: Enhance autocomplete cache with async initialization and improved eviction logic #8367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed eviction logic
Contributor
There was a problem hiding this comment.
3 issues found across 3 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="core/autocomplete/util/AutocompleteLruCache.ts">
<violation number="1" location="core/autocomplete/util/AutocompleteLruCache.ts:218">
After close(), we need to clear the singleton so future get() calls reinitialize a fresh cache; otherwise callers receive an instance whose DB connection is already closed and whose flush timer never restarts.</violation>
</file>
<file name="core/autocomplete/util/AutocompleteLruCache.test.ts">
<violation number="1" location="core/autocomplete/util/AutocompleteLruCache.test.ts:4">
Mocking `async-mutex` removes the real Mutex implementation, so `cache.put` fails when it tries to call `this.mutex.acquire()`.</violation>
<violation number="2" location="core/autocomplete/util/AutocompleteLruCache.test.ts:638">
`jest.doMock("sqlite", …)` runs after AutocompleteLruCache imported `open`, leaving `open` as the default auto-mock and causing `AutocompleteLruCache.get()` to crash with an undefined database handle.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
RomneyDa
approved these changes
Nov 12, 2025
Collaborator
|
@Ayyanaruto appreciate this contribution! |
Contributor
Author
|
Pleasure is all mine |
Contributor
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion #8315 Implement asynchronous initialization for the autocomplete cache and refine eviction logic to optimize performance and memory usage. This update ensures a more efficient handling of cached entries with SQLite persistence.
Summary by cubic
Initialize the autocomplete cache asynchronously and move lookups to an in-memory LRU with periodic SQLite persistence. This improves startup, speeds up cache hits, and tightens eviction for better memory usage.