Fix terminal security check evaluatePolicy type definition #8226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type incorrectly referenced 'evaluatePolicy' instead of 'evaluateToolCallPolicy', which is the actual field name in the Tool interface. This prevented TypeScript from properly enforcing the omission of this field when serializing tools for the browser. Fixes CON-4401 Generated with [Continue](https://continue.dev) Co-authored-by: Continue <noreply@continue.dev> Co-authored-by: nate@continue.dev
|
RomneyDa
approved these changes
Oct 17, 2025
Contributor
|
🎉 This PR is included in version 1.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a typo in the
BrowserSerializedContinueConfigtype definition where it incorrectly referenced'evaluatePolicy'instead of'evaluateToolCallPolicy'.Root Cause
The
Toolinterface has a field calledevaluateToolCallPolicy, but theBrowserSerializedContinueConfigtype was usingOmit<Tool, "preprocessArgs", "evaluatePolicy">instead of the correctOmit<Tool, "preprocessArgs", "evaluateToolCallPolicy">.This typo meant TypeScript was not properly enforcing the omission of the
evaluateToolCallPolicyfield when tools were serialized for the browser, which could have led to runtime issues if GUI code attempted to access this function (which should only exist on the core side).Changes
core/index.d.tsto use the correct field nameevaluateToolCallPolicyTesting
evaluateToolCallPolicyis omitted from serialized toolsFixes CON-4401
This agent session was co-authored by nate and Continue.
Summary by cubic
Corrected BrowserSerializedContinueConfig to omit evaluateToolCallPolicy (not evaluatePolicy) so browser-serialized tools don’t expose core-only policy checks. Fixes CON-4401.