-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Background / Async / Remote mode: Kickoff in /agents when you are in the extension #8191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
✅ Review Complete Code Review Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 11 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="gui/src/components/BackgroundMode/AgentsList.tsx">
<violation number="1" location="gui/src/components/BackgroundMode/AgentsList.tsx:40">
`setIsLoading(true)` runs before every polling request, so the list flips back to the loading spinner every 10s even when data is already shown. Please avoid resetting the loading state during background polls (e.g., only set it during the initial load or when data is actually empty).</violation>
</file>
<file name="gui/src/components/BackgroundMode/BackgroundModeView.tsx">
<violation number="1" location="gui/src/components/BackgroundMode/BackgroundModeView.tsx:19">
onCreateAgent is destructured here but never referenced, so passing the callback into BackgroundModeView has no effect. Remove the prop or wire it up where tasks are created.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting that this doesn't specify configYaml or agentFile so will always use the default agent
|
Thanks @RomneyDa! It's fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 7 files
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Background / Async / Remote mode: Kickoff in /agents when you are in the extension
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Adds Background Agents: a new mode to trigger long-running agents for your repo and a UI to list and open them. Addresses Linear CON-4203 by enabling agent creation tied to the current workspace and organization.