Skip to content

Conversation

@tingwai
Copy link
Contributor

@tingwai tingwai commented Sep 9, 2025

Description

Screenshot 2025-09-09 at 1 49 02 PM

Originally had it italicize the text too but I couldn't figure out how to do multi-line italics, ink would only just render the first line :/ There's also a visual bug unrelated to this PR with some models response's where the dot and vertical alignment don't line up (as seen in this screenshot)

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Render ... blocks in the CLI as italic gray text to clearly distinguish thinking content, and ignore these tags inside code blocks. Implements CON-3771.

  • New Features
    • Render blocks as italic gray text
    • Do not process tags inside code blocks
    • Tests for multiple tags, multiline content, and code-block cases

@tingwai tingwai requested a review from a team as a code owner September 9, 2025 20:17
@tingwai tingwai requested review from tomasz-stefaniak and removed request for a team September 9, 2025 20:17
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

@tingwai tingwai changed the title feat: italicize thinking tags feat: italicize and dim thinking tags Sep 9, 2025
@tingwai tingwai force-pushed the tingwai/con-3771-thinking-tags branch from cb9433c to 4489a2f Compare September 9, 2025 20:42
@tingwai tingwai changed the title feat: italicize and dim thinking tags feat: parse for thinking tags and dim them Sep 9, 2025
@tingwai tingwai force-pushed the tingwai/con-3771-thinking-tags branch from 4489a2f to 01b60ca Compare September 9, 2025 20:48
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very concise!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2025
@sestinj sestinj merged commit 0b7b6c4 into main Sep 10, 2025
56 checks passed
@sestinj sestinj deleted the tingwai/con-3771-thinking-tags branch September 10, 2025 21:50
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Sep 10, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 11, 2025

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants